That's a neat idea - if the exception handler catches OSError with error number 
18 (Invalid cross-device link) in os.rename, it should attempt shutil.move, 
otherwise it should re-throw the exception with raise. A wrapper function will 
make it easier to handle other situations as they arise. I'll update the patch.

Thanks,
Devendra

> Em 21 de abr. de 2021, à(s) 15:10, Richard Purdie 
> <richard.pur...@linuxfoundation.org> escreveu:
> 
> On Wed, 2021-04-21 at 11:43 -0300, Devendra Tewari wrote:
>> I created an image for Raspberry Pi Zero W from code at  
>> https://github.com/tewarid/docker-meta-raspberrypi/tree/sstate, using Docker 
>> for macOS, and on Ubuntu 20.04-
>> LTS, and wrote it out to an SDCard using bmaptool. Booted and checked that 
>> busybox symlinks in rootfs look
>> all right.
>> 
>>> Em 21 de abr. de 2021, à(s) 02:22, Khem Raj <raj.k...@gmail.com> escreveu:
>>> 
>>> None of my images are bootable when this patch is applied, because
>>> symlinks that busybox should provide arent created in the image. This
>>> patch should be looked into a bit further,  how was it tested ?
> 
> I think there is some element to this we're not understanding. I'm also
> worried that the exception is quite generic, OSError covers a lot of things
> and we probably need to make it more specific.
> 
> I'd suggest we add a patch changing all the call sites to use a new
> wrapper function in bb.utils and then we can adjust that single site to
> handle issues as they arise and as we understand them.
> 
> Cheers,
> 
> Richard
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150752): 
https://lists.openembedded.org/g/openembedded-core/message/150752
Mute This Topic: https://lists.openembedded.org/mt/81698791/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to