On Thu, Apr 1, 2021 at 4:31 PM Nishanth Menon <n...@ti.com> wrote:
>
> On 09:22-20210401, Bruce Ashfield wrote:
> > On Wed, Mar 31, 2021 at 8:00 PM Denys Dmytriyenko <de...@denix.org> wrote:
> > >
> > > Fixes:
> > > | CALL
> > > /OE/poky-master/build/tmp/work-shared/qemuarm64/kernel-source/scripts/checksyscalls.sh
> > > | CALL
> > > /OE/poky-master/build/tmp/work-shared/qemuarm64/kernel-source/scripts/atomic/check-atomics.sh
> > > | LDS arch/arm64/kernel/vdso/vdso.lds
> > > | CC arch/arm64/kernel/vdso/vgettimeofday.o
> > > | AS arch/arm64/kernel/vdso/note.o
> > > | AS arch/arm64/kernel/vdso/sigreturn.o
> > > | LD arch/arm64/kernel/vdso/vdso.so.dbg
> > > | VDSOSYM include/generated/vdso-offsets.h
> > > | OBJCOPY arch/arm64/kernel/vdso/vdso.so
> > > | objcopy: Unable to recognise the format of the input file
> > > `arch/arm64/kernel/vdso/vdso.so.dbg'
> > > |
> > > /OE/poky-master/build/tmp/work-shared/qemuarm64/kernel-source/arch/arm64/kernel/vdso/Makefile:61:
> > > recipe for target 'arch/arm64/kernel/vdso/vdso.so' failed
> > >
> > > Cc: Bruce Ashfield <bruce.ashfi...@gmail.com>
> >
> > I like the lighter touch of this patch. I still can't explain why this
> > isn't necessary on one of my builders, but is on the other .. but that
> > of course isn't relevant to this!
> >
> > I've reviewed and tested this, so no concerns from my end.
> >
> > Queue the cheesy -by lines:
> >
> > Reviewed-by: Bruce Ashfield <bruce.ashfi...@gmail.com>
> > Acked-by: Bruce Ashfield <bruce.ashfi...@gmail.com>
> > Tested-by: Bruce Ashfield <bruce.ashfi...@gmail.com>
> >
>
> Sounds good to me as well.. Thanks for discussing this chain[1].
>
>
> Tested-by: Nishanth Menon <n...@ti.com>
>
>
> Though I still don't understand the rationale why would we not move
> CROSS_COMPILE from kernel.bbclass to kernel-arch.bbclass instead of
> having to duplicate it here? after all KERNEL_CC etc are in that realm
> and would'nt CROSS_COMPILE fall in that bucket?
It is definitely a valid thing to do as well.
My only hesitation is the timing. We are very close to release, so I'd
prefer the lightest touch fix, which is this one.
We can of course revisit in about a month when the release is out.
Bruce
>
> > > Cc: Nishanth Menon <n...@ti.com>
> > > Signed-off-by: Denys Dmytriyenko <de...@denix.org>
> > > ---
> > > meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
> > > b/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
> > > index 92ffa47..b2b50b9 100644
> > > --- a/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
> > > +++ b/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb
> > > @@ -19,7 +19,7 @@ DEPENDS += "bc-native bison-native"
> > > DEPENDS += "gmp-native"
> > >
> > > EXTRA_OEMAKE = " HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
> > > HOSTCPP="${BUILD_CPP}""
> > > -EXTRA_OEMAKE += " HOSTCXX="${BUILD_CXX} ${BUILD_CXXFLAGS}
> > > ${BUILD_LDFLAGS}""
> > > +EXTRA_OEMAKE += " HOSTCXX="${BUILD_CXX} ${BUILD_CXXFLAGS}
> > > ${BUILD_LDFLAGS}" CROSS_COMPILE=${TARGET_PREFIX}"
> > >
> > > # Build some host tools under work-shared. CC, LD, and AR are probably
> > > # not used, but this is the historical way of invoking "make scripts".
> > > --
> > > 2.7.4
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
> 849D 1736 249D
>
> [1] https://lists.openembedded.org/g/openembedded-core/message/150143
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#150175):
https://lists.openembedded.org/g/openembedded-core/message/150175
Mute This Topic: https://lists.openembedded.org/mt/81764668/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
