None of the context for the second hunk in the first patch exists. E.g., if I checkout master of poky and grep for “License for package %s” (part of the line that the first patch replaces), there is no match in any file.
//Peter From: Ida Delphine <idad...@gmail.com> Sent: den 17 februari 2021 17:59 To: Peter Kjellerstedt <peter.kjellerst...@axis.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Please what exactly didn't match? Ida On Wed, Feb 17, 2021 at 4:50 PM Peter Kjellerstedt <peter.kjellerst...@axis.com<mailto:peter.kjellerst...@axis.com>> wrote: I tried to apply these patches, but the context does not match. Are there other patches I need to apply before these can be applied? //Peter > -----Original Message----- > From: > openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org> > <openembedded- > c...@lists.openembedded.org<mailto:c...@lists.openembedded.org>> On Behalf Of > Meh Mbeh Ida Delphine > Sent: den 17 februari 2021 05:00 > To: > openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org> > Subject: [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for > improvements? > > Hello everyone, > > The following patchset is aimed at improving the Yocto Project license > tracing. > > Initially, after a build I will come across 130 license warnings with some > false positives. I got rid of these by replacing "or-later" with "+" for > source licenses (computedpkglics) and also passing the recipe license > through canonical_license of license.py(). As a result, some of the > licenses will match during comparism hence some warnings eliminate. > > Though some false positive warnings were eliminated, lots of warnings were > ouputed as a result of several source licenses having "WITH Linux-syscall- > note". With the help of a variable being set in local.conf, one can > chooses whether or not to get lid of the "WITH Linux-syscall-note" string > from the source licenses. Just by doing this, several warnings are dropped > and now left with 118. > > I later on added some logic depending on "source_spdx_license" variable > whether or not for the user to allow the warnings being outputed during > the build. It reduces the extra processing and reduces time if the user > chooses not to display warnings. It uses bb.utils.contains() to find out > if that particular vaiable is present. Also, I added > package_qa_handle_error() to allow the user decide whether they want the > issues treated as warnings, errors or not at all. > > Some of the license-related logic I added to take care of splitting recipe > licences before canonicalizing, getting rid of "or-later" warnings, I > moved it to license.bbclass and put it in functions. I also plan on fixing > the variable naming since some have underscores whereas others do not > have. However, I will love to move more license logic in package.bbclass > to license.bbclass but I need help with the right way to go about it. > Also, general suggestions on any improvements to this are highly welcomed. > > Cheers, > Ida. > > Ida Delphine (5): > package: Remove false positive lic warnings > package: Remove false positive lic warnings > package: Remove false positive lic warnings > license.bbclass: Add functions to split and canonicalise license > strings > package.bbclass: Remove false positive license warnings > > meta/classes/license.bbclass | 27 ++++++++ > meta/classes/package.bbclass | 127 +++++++++++++++++++---------------- > 2 files changed, 96 insertions(+), 58 deletions(-) > > -- > 2.25.1
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#148295): https://lists.openembedded.org/g/openembedded-core/message/148295 Mute This Topic: https://lists.openembedded.org/mt/80697036/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
