On Sun, Jan 31, 2021 at 09:07:50AM +0000, Richard Purdie wrote:
> On Sat, 2021-01-30 at 17:15 +0100, Martin Jansa wrote:
> >
> >
> > On Wed, Jan 27, 2021 at 6:28 PM Richard Purdie <
> > richard.pur...@linuxfoundation.org> wrote:
> > > Some now unneeded code in python3-setuptools is dropped, there are
> > > further
> > > changes like this which can follow.
> > >
> > > This change was verified with OE-Core by comparing task-depends.dot
> > > generated
> > > by "bitbake world -g" before and after the change, the files were
> > > identical.
> > >
> > > diff --git a/meta/recipes-
> > > devtools/python/python3-setuptools_51.0.0.bb b/meta/recipes-
> > > devtools/python/python3-setuptools_51.0.0.bb
> > > index 6ee935f8f79..db336bfa13b 100644
> > > --- a/meta/recipes-devtools/python/python3-setuptools_51.0.0.bb
> > > +++ b/meta/recipes-devtools/python/python3-setuptools_51.0.0.bb
> > > @@ -58,8 +58,3 @@ RDEPENDS_${PYTHON_PN}-pkg-resources = "\
> > > ${PYTHON_PN}-plistlib \
> > > ${PYTHON_PN}-pprint \
> > > "
> > > -# Due to the way OE-Core implemented native recipes, the native
> > > class cannot
> > > -# have a dependency on something that is not a recipe name. Work
> > > around that by
> > > -# manually setting RPROVIDES.
> > > -RDEPENDS_${PN}_append = " ${PYTHON_PN}-pkg-resources"
> > > -RPROVIDES_append_class-native = " ${PYTHON_PN}-pkg-resources-
> > > native"
> > >
> >
> > The runtime dependency on ${PYTHON_PN}-pkg-resources isn't needed
> > anymore? I don't see how it would get still included as you said that
> > bitbake -g files were the same.
>
> I think you're right and I shouldn't have removed the RDEPENDS, only
> the RPROVIDES. bitbake -g are task dependencies and the task
> dependencies still showed up so this didn't highlight any issue.
>
> I'll test a patch to fix that and add it back, probably in the main
> RDEPENDS list.OK, I've sent similar fix for meta-python2: https://lists.openembedded.org/g/openembedded-devel/message/89200 > > I'm asking because meta-python2 has the same issue in: > > https://git.openembedded.org/meta-python2/tree/recipes-devtools/python/python-setuptools.inc#n49 > > > > and my fix I was planing to send was to replace it with: > > RDEPENDS_${PN}_append_class-target = " ${PYTHON_PN}-pkg-resources" > > and drop the RPROVIDES, because it unfortunately causes bitbake to > > get stuck after reporting parsing error as: > > > > ERROR: meta-python2/recipes-devtools/python/python- > > setuptools_42.0.2.bb: QA Issue: meta-python2/recipes- > > devtools/python/python-setuptools_42.0.2.bb: Variable RPROVIDES is > > set as not being package specific, please fix this. [pkgvarcheck] > > ERROR: meta-python2/recipes-devtools/python/python- > > setuptools_42.0.2.bb: Fatal QA errors found, failing task. > > ERROR: Failed to parse recipe: meta-python2/recipes- > > devtools/python/python-setuptools_42.0.2.bb > > Are you saying that it does that with the RPROVIDES removed? That seems > odd :/ No, this was before removing RPROVIDES in meta-python2, I was just surprised that bitbake got stuck after reporting parsing failure, I'm seeing bitbake getting stuck in dunfell builds quite often, but don't remember seeing it with gatesgarth and newer (and was believing that you have already fixed most if not all cases there). But it's also true that our jenkins runs 1000x more builds based on dunfell, so it's much more likely to happen there. Cheers,
signature.asc
Description: PGP signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147484): https://lists.openembedded.org/g/openembedded-core/message/147484 Mute This Topic: https://lists.openembedded.org/mt/80162703/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
