Hi Dorinda, On Tue, Jan 26, 2021 at 01:53:47AM +0100, Dorinda wrote: > If a user builds in a path in PSEUDO_IGNORE_PATHS, random failures are > generated. Hence this patch adds a sanity check in sanity.bbclass to ensure > that a user isn't building in PSEUDO_IGNORE_PATHS. >
Commit log is usually wraped when reaching a given length. I personally have it set to 72 characters which IIRC is what's used for kernel contribution. This does not apply to actual logs provided in the commit log. It's just nitpick, as I saw a commit or two not following this implicit "rule" in poky, I'd say there's no need to resend a patch just for this. Also, please add a version tag when you send revamped patches. You can do that by adding -v 2 to git format-patch. > [YOCTO #14179] > > Signed-off-by: Dorinda Bassey <dorindabas...@gmail.com> > --- And if you want to do it really the very nice way (IMO, as always), you can provide below the --- (the one above this) and the list of files changed (the one below this), you can list what has changed between v N-1 and v N. e.g. v2: - rephrased error log, - added a check for empty paths in pseudoignorepaths, > meta/classes/sanity.bbclass | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index e527c13746..c6842ff549 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass Only nitpicks, so nothing to be done on my side if no new change is requested by other reviewers. Cheers, Quentin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147246): https://lists.openembedded.org/g/openembedded-core/message/147246 Mute This Topic: https://lists.openembedded.org/mt/80117826/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
