On Tue, 2021-01-12 at 17:53 +0000, chris.lapla...@agilent.com wrote:
> Hi Richard,
> 
> > > 
> > > +do_fetch[lockfiles] += "${DL_DIR}/npm2_fetch.lock"
> > > +
> > >  def npm_global_configs(d):
> > >      """Get the npm global configuration"""
> > >      configs = []
> > 
> > If its just multilib, you could put a ${BPN} in the lock name? or is it 
> > conflicting
> > general recipes?
> 
> multiconfig, not multilib.
> 
> But it would happen even without multiconfig, if there is overlap in
> the node modules that two recipes try to fetch. For some reason the
> npmsw fetcher (or the proxy fetcher it is using, see
> bitbake/lib/bb/fetch2/npmsw.py around lines 168-181) are not guarding
> against two recipes trying to download the same module concurrently.

Sorry, right. If this isn't multiconfig safe, its also not safe against
concurrent builds against DL_DIR which we do support and allow.

It does sound like there are locks missing in the fetcher code and this
is working around that. Could we add the right locks to the fetcher?

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#146624): 
https://lists.openembedded.org/g/openembedded-core/message/146624
Mute This Topic: https://lists.openembedded.org/mt/79627859/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to