On 2020-12-02 4:19 p.m., Nathan Rossi wrote: > On Thu, 3 Dec 2020 at 05:17, Scott Branden <scott.bran...@broadcom.com> wrote: >> Hi Nathan, >> >> Your commit: >> "cml1.bbclass: Handle ncurses-native being available via pkg-config" >> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=master-next&id=ce447d70df386ca55ce1672478b245851556374e >> >> breaks bitbake menuconfig when using the upstream kernel. > Interesting. The purpose of the commit was to actually fix that exact > use case since previously the mainline kernel menuconfig was relying > on hardcoded paths to the host ncurses libraries. > > Would you be able to provide the error messages you are getting (and > anything else that can help to reproduce the failure), because I am > not able to reproduce any failures with a mainline kernel, linux-yocto > (with and without the below mention patch) or with other projects that > are using cml1 (e.g. u-boot). > >> It only works with the linux-yocto kernel due to this workaround which is >> not upstream. >> If you revert this commit in linux-yocto menuconfig will not work in >> linux-yocto: >> "menuconfig,mconf-cfg: Allow specification of ncurses location" >> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/scripts/kconfig/mconf-cfg.sh?h=v5.8/standard/base&id=1714a5ad9cf61f4d0f4b8432f327cca2998aba77 > This change should not be required to have menuconfig working when > pkg-config is used. > >> >> Seems like your commit needs to be reverted or a change made to work with >> the upstream kernel. >> Or, the linux-yocto change needs to actually be upstreamed. I submitted it >> and the upstream maintainer questioned why the change is needed: >> https://lore.kernel.org/lkml/cak7lnatd0j3c_mfrxaju8-wmdcmrpmrfn7um0yebnfl-_zc...@mail.gmail.com/ > The problem is if it was accepted, every kernel prior to its inclusion > would need to be patched, as well as other projects (u-boot, busybox). > This makes supporting menuconfig using that change for kconfig > generically problematic. This is why the pkg-config solution is > preferable. The kernel works with menuconfig without your yocto change today. Only linux-yocto (with the patch mentioned above) works with your yocto change. > > Regards, > Nathan
smime.p7s
Description: S/MIME Cryptographic Signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#145245): https://lists.openembedded.org/g/openembedded-core/message/145245 Mute This Topic: https://lists.openembedded.org/mt/78667947/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
