> -----Original Message-----
> From: [email protected] <openembedded-
> [email protected]> On Behalf Of Bruce Ashfield
> Sent: Friday, November 13, 2020 10:42 AM
> To: Li, Lili <[email protected]>
> Cc: Patches and discussions about the oe-core layer <openembedded-
> [email protected]>; Mittal, Anuj <[email protected]>; Pan,
> Kris <[email protected]>
> Subject: Re: [OE-core][gatesgarth][dunfell][master][PATCH] kernel.bbclass: fix
> module.lds missing issue since kernel v5.10
>
> On Thu, Nov 12, 2020 at 9:11 PM Lili Li <[email protected]> wrote:
> >
> > With v5.10-rc1 kernel commit 596b0474d3d9 (kbuild: preprocess module
> > linker script), external kernel module need scripts/module.lds for
> > compiling.
> >
> > Error Log:
> > *** No rule to make target 'scripts/module.lds', needed by ....
>
> I have a similar change locally, but I do have a question.
>
> >
> > Signed-off-by: Pan, Kris <[email protected]>
> > Signed-off-by: Lili Li <[email protected]>
> > ---
> > meta/classes/kernel.bbclass | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index 9e3c34ad48..5c262f340e 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -358,6 +358,10 @@ do_compile_kernelmodules() {
> > # other kernel modules and will look at this
> > # file to do symbol lookups
> > cp ${B}/Module.symvers ${STAGING_KERNEL_BUILDDIR}/
> > + if [ -e ${B}/scripts/module.lds ]; then
> > + mkdir -p ${STAGING_KERNEL_BUILDDIR}/scripts
> > + cp ${B}/scripts/module.lds
> ${STAGING_KERNEL_BUILDDIR}/scripts/
> > + fi
>
> You really shouldn't need this here.
>
> The only reason we copy Module.symvers is that the kernel module build
> updates it.
>
> I only have the single copy in my local change (since it is created by
> modules_prepare), and I'm not seeing any breakage.
>
> Were you seeing somewhere that it was updated, or something that was
> breaking ?
>
> Bruce
Thanks Bruce for catching this! I add this here just in case any further
changes, we can remove it as of current process.
Will you post your local patch or do you want me to submit v2 version?
Thanks
>
> > else
> > bbnote "no modules to compile"
> > fi
> > @@ -465,6 +469,11 @@ do_shared_workdir () {
> > # Copy files required for module builds
> > cp System.map $kerneldir/System.map-${KERNEL_VERSION}
> > [ -e Module.symvers ] && cp Module.symvers $kerneldir/
> > + if [ -e ./scripts/module.lds ]; then
> > + mkdir -p $kerneldir/scripts
> > + cp ./scripts/module.lds $kerneldir/scripts/
> > + fi
> > +
> > cp .config $kerneldir/
> > mkdir -p $kerneldir/include/config
> > cp include/config/kernel.release
> > $kerneldir/include/config/kernel.release
> > --
> > 2.17.1
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at
> its
> end
> - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#144541):
https://lists.openembedded.org/g/openembedded-core/message/144541
Mute This Topic: https://lists.openembedded.org/mt/78221736/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
