On Thu, Nov 12, 2020 at 12:02 PM Yann Dirson <yann.dir...@blade-group.com> wrote: > > > > Le mar. 22 sept. 2020 à 02:41, Bruce Ashfield <bruce.ashfi...@gmail.com> a > écrit : >> >> On Mon, Sep 21, 2020 at 6:51 PM Richard Purdie >> <richard.pur...@linuxfoundation.org> wrote: >> > >> > On Mon, 2020-09-21 at 23:23 +0200, Yann Dirson wrote: >> > > >> > > >> > > Le lun. 21 sept. 2020 à 21:46, Richard Purdie < >> > > richard.pur...@linuxfoundation.org> a écrit : >> > > > On Mon, 2020-09-21 at 16:15 +0200, Yann Dirson wrote: >> > > > > From: Yann Dirson <y...@blade-group.com> >> > > > > >> > > > > --- >> > > > > meta/classes/systemtap.bbclass | 74 >> > > > +++++++++++++++++++ >> > > > > .../systemtap/systemtap-demo_git.bb | 71 >> > > > ++++++++++++++++++ >> > > > > 2 files changed, 145 insertions(+) >> > > > > create mode 100644 meta/classes/systemtap.bbclass >> > > > > create mode 100644 meta/recipes-kernel/systemtap/systemtap- >> > > > demo_git.bb >> > > > >> > > > I'm afraid this patch is going to throw warnings all over the >> > > > autobuilder, e.g.: >> > > > >> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2488 >> > > > >> > > > (and there will be more). >> > > > >> > > > We are trying to ensure all warnings are solved so that any that do >> > > > show are real issues and this patch would significantly distract >> > > > from >> > > > that. >> > > >> > > OK, we could default to built just the handful of probes that should >> > > always build, and give instructions for those willing to use the >> > > current behaviour. >> > >> > I think that is going to be safer and we could grow into more examples >> > if/as/when we van build them. >> >> Also, as the person that usually picks up systemtap breakage first >> on our new kernel versions .. we need to make sure that the reworked >> recipe and class pass the oe-selftest for stap. > > > AFAICT, if we exclude this last patch, the only impact on tests is that those > testing modules with crosstap (which I only learnt about when looking for > those tests) > and pulling the full systemtap package should be changed to pull > systemtap-runtime > instead. > > Now adding tests for the modules built with systemtap.class is a different > thing. > >> It is doing on target compilation, so ideally, that test should be expanded >> to test bot the cross and on-target variants. > > > The on-target compilation is already tested by > meta/lib/oeqa/runtime/cases/stap.py, > and there are crosstap tests in meta/lib/oeqa/selftest/cases/runtime_test.py.
I'm aware of that ..... I'm the one that runs them against most new kernels :D Bruce > > I have started to look at adding a test for modules cross-built by > systemtap.bbclass, > but as it takes ages to run those tests it seems it would make sense to move > this last > patch into a series of its own. > > >> >> >> Cheers, >> >> Bruce >> >> > >> > > >> > > > I'm also wary that we're now in feature freeze for release so >> > > > perhaps >> > > > these changes should wait until 3.3? >> > > >> > > OK, I can reroll a series with just the fixes. >> > >> > That would be great. >> > >> > > For the rest should I just wait for the gatesgarth branch to be >> > > created and resubmit then ? >> > >> > Once we start taking new work on master, yes. >> > >> > Also, for a new recipe like this we need a maintainers entry, else we >> > see: >> > >> > https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/1377 >> > >> > Cheers, >> > >> > Richard >> > >> > >> > >> > >> > >> >> >> -- >> - Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end >> - "Use the force Harry" - Gandalf, Star Trek II > > > > -- > Yann Dirson <y...@blade-group.com> > Blade / Shadow -- http://shadow.tech > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144518): https://lists.openembedded.org/g/openembedded-core/message/144518 Mute This Topic: https://lists.openembedded.org/mt/76990992/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
