On Fri, Sep 11, 2020 at 12:47:44PM +0100, Ross Burton wrote:
> > +python () {
> > + # Change the default compression algorithm if requested.
> > + comp_default = d.getVar('SQUASHFS_TOOLS_COMP_DEFAULT')
> > + if comp_default != None:
> > + d.appendVar('EXTRA_OEMAKE', ' COMP_DEFAULT=%s' % comp_default)
> > +}
> > +
>
> This is overcomplicated. Just do:
>
> SQUASHFS_TOOLS_COMP_DEFAULT ?= "gzip"
> EXTRA_OEMAKE += "COMP_DEFAULT=${SQUASHFS_TOOLS_COMP_DEFAULT}"
>
> This way the default is documented in the recipe, and we can change
> the default easily too.
ACK. V2 coming.
Thanks,
Peter.
>
> Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#142441):
https://lists.openembedded.org/g/openembedded-core/message/142441
Mute This Topic: https://lists.openembedded.org/mt/76776791/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
