Quentin,

Thanks for the feedback, and I will resend this.  I started off with a
patch which contained the original authors, but that was lost in the
process of applying the patch, since it is a patch of a patch.  I was
attempting to avoid patch fuzzing, since it had previously been
applied to pppd 2.4.8.  Is a small amount of fuzz acceptable?

-M

On Tue, Jul 14, 2020 at 11:14 AM Quentin Schulz
<quentin.sch...@streamunlimited.com> wrote:
>
> Hi Mark,
>
> On Tue, Jul 14, 2020 at 11:04:41AM -0400, Mark Deneen wrote:
> > pppd is patched in most Linux distributions to allow arbitrary naming
> > of ppp interfaces, allowing users to create consistent firewall rules
> > rather than having interfaces named "ppp0", "ppp1", etc.  Yocto is
> > missing this option.
> >
> > This patch, originally from SUSE, adds this option to pppd. It is not
> > included upstream because there are some pppd-supported platforms which
> > lack the ability to rename interfaces.
> >
> > Signed-off-by: Mark Deneen <mden...@gmail.com>
>
> Please follow guidelines from:
> https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
> to know how to contribute in a way that is matching OE patch management.
>
> Your mail content should probably be the content of the commit log. Your
> mail should directly be the output of git format-patch (send it with
> git send-email), the patch shouldn't be attached to the mail but rather
> "be" the mail.
>
> On the content of the patch, it'd be nice to take the patch with the
> authors, commit title and log from the original place where you took it
> from.
>
> It probably is:
> https://sources.debian.org/patches/ppp/2.4.6-3.1/ppp-2.4.2-ifname.diff/
> ?
>
> No author, no commit log :/ Though, I could find
> https://sources.debian.org/patches/ppp/2.4.6-3.1/ppp-2.4.2-ifname.diff/
> which is slightly different and the changelog seems decent between
> Suse's and debian's patch.
>
> Thanks,
> Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#140619): 
https://lists.openembedded.org/g/openembedded-core/message/140619
Mute This Topic: https://lists.openembedded.org/mt/75500647/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to