> That sort of error would typically be caused by the variable being > unset rather than the variable being set to the path of a nonexistent > file. I don't know much about the context this script runs in though > so I may be missing something obvious.
You're right but a "! -f" takes care of both the cases where the var is unset of the file isn't present. BR, Awais ________________________________________ From: Paul Barker <pbar...@konsulko.com> Sent: Thursday, June 18, 2020 12:50 PM To: Belal, Awais Cc: openembedded-core Subject: Re: [OE-core] [PATCH] toolchain-shar-relocate.sh: check for environment-setup beforehand On Wed, 17 Jun 2020 at 21:48, Awais Belal <awais_be...@mentor.com> wrote: > > The script runs a 'cat' on the script and if it isn't present in the > sdk the cat command waits on the std input and hence the installation > process simply sits there. That sort of error would typically be caused by the variable being unset rather than the variable being set to the path of a nonexistent file. I don't know much about the context this script runs in though so I may be missing something obvious. > > Signed-off-by: Awais Belal <awais_be...@mentor.com> > --- > meta/files/toolchain-shar-relocate.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/meta/files/toolchain-shar-relocate.sh > b/meta/files/toolchain-shar-relocate.sh > index e3c10018ef..02a05664c6 100644 > --- a/meta/files/toolchain-shar-relocate.sh > +++ b/meta/files/toolchain-shar-relocate.sh > @@ -3,6 +3,12 @@ if ! xargs --version > /dev/null 2>&1; then > exit 1 > fi > > +# check if we have a valid env-setup script > +if [ ! -f "$env_setup_script" ]; then > + echo "Main environment-setup file not found. Abort!" > + exit 1 > +fi > + > # fix dynamic loader paths in all ELF SDK binaries > native_sysroot=$($SUDO_EXEC cat $env_setup_script |grep > 'OECORE_NATIVE_SYSROOT='|cut -d'=' -f2|tr -d '"') > dl_path=$($SUDO_EXEC find $native_sysroot/lib -name "ld-linux*") > -- > 2.17.1 -- Paul Barker Konsulko Group
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139636): https://lists.openembedded.org/g/openembedded-core/message/139636 Mute This Topic: https://lists.openembedded.org/mt/74946187/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
