Yes, I think it is what Richard says. But, that's a specific case, and I think that, in general, it would be better to look for something that does work. Like my glorious leader says, "What have you got to lose?"
The change does print out a warning, so you can check out what the problem is, if you care to. Joe -----Original Message----- From: Richard Purdie <richard.pur...@linuxfoundation.org> Sent: Thursday, May 21, 2020 1:55 PM To: MacLeod, Randy <randy.macl...@windriver.com>; Slater, Joseph <joe.sla...@windriver.com>; openembedded-core@lists.openembedded.org Subject: Re: [oe-core][PATCH 1/1] terminal.py: do not stop searching for auto On Thu, 2020-05-21 at 15:52 -0400, Randy MacLeod wrote: > On 2020-05-21 2:41 p.m., Joe Slater wrote: > > If a terminal fails to spawn() we should continue looking. > > gnome-terminal, in particular can be present but not start. > > Do you mean that it doesn't start on the first try but that it may / > usually does start on subsequent tries? > > Since the user has set the preferred terminal, this change could > confuse them and therefore seems wrong. > If we know of flaky terminal implementations, why not look for > specific versions, issue a warning and either retry or tell the user > to try again? In a few years, we can discard the code when the flaky > terminal version is no longer used. > > Is there a bug open with gnome-terminal to track this? > What distro/gnome-terminal do you see this problem in? I suspect the issue is more like gnome-terminal is present as a binary but no X desktop is running... Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138566): https://lists.openembedded.org/g/openembedded-core/message/138566 Mute This Topic: https://lists.openembedded.org/mt/74382353/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
