On Fri, Dec 9, 2011 at 12:18, Richard Purdie <
richard.pur...@linuxfoundation.org> wrote:
> This patch appears to:
>
> a) Remove multilib support from the recipe
>
Fixed.
> b) Drop the git version of the recipe (no mention of this above?)
>
I moved it to another commit.
> c) Add a pointless rdepends = d.getVar( "RDEPENDS_%s" % package)
>
Fixed.
> d) Remove the dnsproxy, dhclient and test options
>
Fixed.
> e) Add the tools, fake and ntpd options
>
Fixed.
> f) Reorder variables in the file so as to make the diff unreadable and
> hard to review
>
This was indeed done and I am sorry but it does seems more easy to follow
now.
> g) Change the contents of the ${PN}-scripts package
>
> h) Add tools and tests packages
>
> i) Add a dependeny on ntp
>
Fixed.
> j) Uses bitbake master funtionality (d.expand()) which will break on
> older versions of bitbake (we need to increase the bitbake minimum
> version)
>
Fixed adding a commit that bumps it.
> k) Drops the python scripts dependency
>
Fixed.
> So all things considered, this kind of change is a nightmare to review
> in this form and the commit message only covers half the changes it
> makes. We need to do better than this...
Not easy to accomplish as the difference between meta-oe and oe-core on
this was huge. It could have been done better, sure ... and a v2 patch
will come shortly.
--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
