Thanks, but it still starts and terminates PRServer immediately, right? With your fix, all my builds now start with:
NOTE: Started PRServer with DBfile: /OE/build/oe-core/cache/prserv.sqlite3, IP: 127.0.0.1, PORT: 34335, PID: 9429 NOTE: Terminating PRServer... NOTE: Started PRServer with DBfile: /OE/build/oe-core/cache/prserv.sqlite3, IP: 127.0.0.1, PORT: 45753, PID: 9433 before this I was using: https://github.com/shr-distribution/bitbake/commit/728d9ec3b3448bba91a3cc0d505b804e702aec4b which doesn't start it just to terminate it, but RP said that my fix doesn't look correct, so I haven't sent it to ML. BTW: bitbake patches should go to bitbake-devel ML not oe-core ML. On Mon, Nov 11, 2019 at 11:15 PM <gavi...@thegavinli.com> wrote: > From: Gavin Li <ga...@matician.com> > > With PRSERV_HOST = "localhost:0", this message would occasionally pop up > during the initial cache read: > > WARNING: /home/matic/ambayocto/poky/bitbake/lib/bb/cache.py:446: > ResourceWarning: unclosed <socket.socket fd=10, > family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, > laddr=('127.0.0.1', 45655)> > value = pickled.load() > > The file location stated is irrelevant; it just happens to be wherever > CPython decides to run the garbage collector. The issue is that after we > fork off a PRServer, self.socket is also duplicated. The parent side of > it also needs to be closed. > > Signed-off-by: Gavin Li <ga...@matician.com> > --- > bitbake/lib/prserv/serv.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py > index be3acec36a..1d9148b817 100644 > --- a/bitbake/lib/prserv/serv.py > +++ b/bitbake/lib/prserv/serv.py > @@ -243,6 +243,7 @@ class PRServer(SimpleXMLRPCServer): > try: > pid = os.fork() > if pid > 0: > + self.socket.close() # avoid ResourceWarning in parent > return pid > except OSError as e: > raise Exception("%s [%d]" % (e.strerror, e.errno)) > -- > 2.23.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core >
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
