Op 30 nov. 2011, om 06:57 heeft Mei Lei het volgende geschreven:

> Signed-off-by: Mei Lei <lei....@intel.com>

So the commit summary says 'upgrade', but look here:

> --- a/meta/recipes-core/dropbear/dropbear.inc
> +++ b/meta/recipes-core/dropbear/dropbear.inc
> @@ -16,7 +16,6 @@ SRC_URI = 
> "http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.gz \
>                file://dropbear-0.53.1-static_build_fix.patch \
>                file://configure.patch \
>                file://fix-2kb-keys.patch \
> -              file://allow-nopw.patch;apply=no \

Why did you remove that?

>                file://init \
>                  ${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_SRC_URI}', 
> '', d)} "
> 
> @@ -40,13 +39,6 @@ EXTRA_OECONF += "\
> 
> DISTRO_TYPE ?= "${@base_contains("IMAGE_FEATURES", "debug-tweaks", "debug", 
> "",d)}"
> 
> -do_debug_patch() {
> -     if [ "${DISTRO_TYPE}" = "debug" ]; then
> -             bbnote "WARNING: applying allow-nopw.patch which allows 
> password-less logins!"
> -             patch -p1 < ${WORKDIR}/allow-nopw.patch
> -     fi
> -}
> -

And why did you remove that as well?

> addtask do_debug_patch after do_patch before do_configure

After removing the previous 2, why did you leave this one in?

Why are you breaking passwwdless logins without mentioning it in the commit 
summary!?!?!?

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to