Right so we should only disable the tunes which don’t have clz and not all mips as this patch is doing
On Tue, Jul 16, 2019 at 10:42 PM Kang Kai <kai.k...@windriver.com> wrote: > On 2019/7/16 下午11:33, Khem Raj wrote: > > > > On Tue, Jul 16, 2019 at 2:33 AM Kang Kai <kai.k...@windriver.com> wrote: > >> On 2019/7/16 下午3:19, Khem Raj wrote: >> > On Mon, Jul 15, 2019 at 3:21 AM <kai.k...@windriver.com> wrote: >> >> From: Kai Kang <kai.k...@windriver.com> >> >> >> >> It fails to compile webkit when default tune is 'mips': >> >> >> >> | >> .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2 >> >> | /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23: >> >> | error: static assertion failed: CLZ opcode is not available for this >> ISA >> >> >> >> So don't build webkit when default tune is mips. >> >> >> >> Signed-off-by: Kai Kang <kai.k...@windriver.com> >> >> --- >> >> meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++ >> >> 1 file changed, 2 insertions(+) >> >> >> >> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> index 056334fff5..891266b220 100644 >> >> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> @@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo >> libxslt libxt libidn libgcrypt \ >> >> gettext-native glib-2.0 glib-2.0-native libtasn1 \ >> >> " >> >> >> >> +COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', >> 'mips', 'null', 'mips.*-linux', d)}" >> <$%7B@bb.utils.contains('DEFAULTTUNE','mips','null','mips.*-linux',d)%7D> >> >> + >> > this disables is for all kind of mips. I think thats a broad set, it >> > would be best to narrow it to what you saw it failing for >> > e.g. it should work for mips32 and mips64 so maybe mips1 is what you >> > want to disable for >> >> I tested with qemumips and qemumips64. When set >> >> DEFAULTTUNE= "mips" > > > How about using mips32 and mips64 for default tune and retest > > > It build webkitgtk successfully on qemumips and qemumips64 with default > tune mips32 and mips64. > > > >> >> It fails with the error. >> >> Regards, >> Kai >> >> > >> > >> >> PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', >> 'x11', 'wayland' ,d)} \ >> >> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', >> 'webgl opengl', '' ,d)} \ >> >> enchant \ >> >> -- >> >> 2.20.0 >> >> >> >> -- >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >> >> -- >> Kai Kang >> >> > -- > Kai Kang > >
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core