+KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B}
olddefconfig || yes '' | oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}"
oldnoconfig"It's the 2 apostrophes after "yes", which look like double quotes in the font used in gmail, sorry. On Tue, Oct 30, 2018 at 7:58 PM Bruce Ashfield <bruce.ashfi...@windriver.com> wrote: > On 2018-10-30 2:51 PM, Martin Jansa wrote: > Agreed with Andre, also the quotes in new version don't match, which > > makes me wonder how well this was actually tested. > > Where are you seeing the non matching quotes ? The CC="" blocks > have been there for a while, and haven't caused any issues. > Other than that, I'm seeing matched "", '' and the entire command > wrapped in "". > > It was tested by running configure, definitely worked here. > > The 'yes' in the pipeline is just in case there is some kernel > somewhere with a patch, and the pipeline could stall. Since it > is the last option in the compound statement, I definitely wanted > it to complete. > > I can drop the yes, but I'm pretty sure the extra overhead wouldn't > have harmed anyone. > > > > > Using apostrophes inside quoted string value would make it easier to see > > that there is extra " after the useless yes call. > > I'm still not seeing the extra quote. > > Bruce > > > > > On Tue, Oct 30, 2018 at 6:31 PM Andre McCurdy <armccu...@gmail.com > > <mailto:armccu...@gmail.com>> wrote: > > > > On Tue, Oct 30, 2018 at 10:17 AM Bruce Ashfield > > <bruce.ashfi...@windriver.com <mailto:bruce.ashfi...@windriver.com>> > > wrote: > > > > > > On 10/30/18 1:02 PM, Andre McCurdy wrote: > > > > On Mon, Oct 29, 2018 at 8:39 PM Bruce Ashfield > > > > <bruce.ashfi...@windriver.com > > <mailto:bruce.ashfi...@windriver.com>> wrote: > > > >> > > > >> As was warned by commit 312ee68752fa [kconfig: announce > removal of > > > >> oldnoconfig if used], oldnoconfig has been removed from the > > 4.20 kernel. > > > >> > > > >> So we switch our default mode to olddefconfig. > > > >> > > > >> commit fb16d8912 [kconfig: replace 'oldnoconfig' with > > 'olddefconfig', > > > >> and keep the old name as an alias] introduced olddefconfig in > > the 3.10 > > > >> kernel, we shuffle oldnoconfig to the fallback target. > > > >> > > > >> The fallback mode allows kernels between 3.10 and the > > currently listed > > > >> oldest kernel of 3.2 to continue to configure. > > > >> > > > >> Signed-off-by: Bruce Ashfield <bruce.ashfi...@windriver.com > > <mailto:bruce.ashfi...@windriver.com>> > > > >> --- > > > >> > > > >> v2: Tweaked to add a fallback mode as suggested by Andre > McCurdy > > > >> > > > >> Not for the release, just wanted to get this in the queue for > > > >> when master reopens so we'll be ready for 4.20+ kernel versions > > > >> > > > >> Bruce > > > >> > > > >> > > > >> meta/classes/kernel.bbclass | 2 +- > > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> > > > >> diff --git a/meta/classes/kernel.bbclass > > b/meta/classes/kernel.bbclass > > > >> index e04d2fe00434..8fe207165ae8 100644 > > > >> --- a/meta/classes/kernel.bbclass > > > >> +++ b/meta/classes/kernel.bbclass > > > >> @@ -492,7 +492,7 @@ sysroot_stage_all () { > > > >> : > > > >> } > > > >> > > > >> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} > > CC="${KERNEL_CC}" O=${B} oldnoconfig" > > > >> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} > > CC="${KERNEL_CC}" O=${B} olddefconfig || yes '' | oe_runmake -C ${S} > > O=${B} CC="${KERNEL_CC}" oldnoconfig" > > > > > > > > There's no "yes" needed with oldnoconfig. The new fallback > > should just > > > > be the existing default command. > > > > > > *shrug* > > > > > > I'll leave this as is, since it works as tested. Feel free to > > > send followups. > > > > "make oldnoconfig" without the "yes" has been well tested for the > past > > few OE releases so it's just odd you decided to change it. Why did > > you? > > > > > >> python check_oldest_kernel() { > > > >> oldest_kernel = d.getVar('OLDEST_KERNEL') > > > >> -- > > > >> 2.5.0 > > > >> > > > >> -- > > > >> _______________________________________________ > > > >> Openembedded-core mailing list > > > >> Openembedded-core@lists.openembedded.org > > <mailto:Openembedded-core@lists.openembedded.org> > > > >> > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > > > -- > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > <mailto:Openembedded-core@lists.openembedded.org> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > >
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
