Hello Ross, Thank you for reviewing.
I am not sure where you saw the commit message say that pyvenv has been removed. What it says about pyvenv is that it is deprecated in python3.6 (to explain why it has been provided via the newly created venv package). Regards Hugues Get Outlook for Android<https://aka.ms/ghei36> ________________________________ From: Burton, Ross <ross.bur...@intel.com> Sent: Tuesday, October 30, 2018 4:06:40 PM To: Hugues Kamba Cc: OE-core Subject: Re: [OE-core] [PATCH v2] python3: Fix python3-pyvenv run-time dependency Patch looks good, but the commit message contradicts itself a few times. python3-pyvenv is removed, but: " This patch adds the python3-venv module as a self-contained package which python3-pyvenv must depend on at run-time." This patch specifies the newly created python3-venv as a run-time dependency of python3-pyvenv." Ross On Tue, 30 Oct 2018 at 13:08, Hugues Kamba <hugues.ka...@arm.com> wrote: > > Pyvenv is just a small script that uses venv to create virtual > environments. > https://www.python.org/dev/peps/pep-0405/#creating-virtual-environments > > This patch adds the python3-venv module as a self-contained package which > python3-pyvenv must depend on at run-time. > > The patch also provides the package python3-pyvenv from the pyhton3-venv > package.This is good for future-proofing since python3-pyvenv has been > deprecated and only python3-venv is now available in Python 3.6. > https://docs.python.org/3/library/venv.html. > > Without this patch python3-pyvenv is broken because it is missing the > venv module at run-time. This patch specifies the newly created > python3-venv as a run-time dependency of python3-pyvenv. > > Signed-off-by: Hugues Kamba <hugues.ka...@arm.com> > --- > .../python/python3/python3-manifest.json | 16 ++++++++++++++++ > meta/recipes-devtools/python/python3_3.5.6.bb | 4 ++-- > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json > b/meta/recipes-devtools/python/python3/python3-manifest.json > index f922561368..ef7fa4ecaf 100644 > --- a/meta/recipes-devtools/python/python3/python3-manifest.json > +++ b/meta/recipes-devtools/python/python3/python3-manifest.json > @@ -1107,6 +1107,22 @@ > "${libdir}/python${PYTHON_MAJMIN}/__pycache__/getpass.*.pyc" > ] > }, > + "venv": { > + "summary": "Provides support for creating lightweight virtual > environments with their own site directories, optionally isolated from system > site directories.", > + "rdepends": [ > + "compression", > + "core", > + "logging", > + "shell", > + "stringold", > + "unixadmin" > + ], > + "files": [ > + "${libdir}/python${PYTHON_MAJMIN}/venv", > + "${bindir}/pyvenv*" > + ], > + "cached": [] > + }, > "xml": { > "summary": "Python basic XML support", > "rdepends": [ > diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb > b/meta/recipes-devtools/python/python3_3.5.6.bb > index 2a4547694a..31f8eada11 100644 > --- a/meta/recipes-devtools/python/python3_3.5.6.bb > +++ b/meta/recipes-devtools/python/python3_3.5.6.bb > @@ -226,8 +226,8 @@ FILES_${PN}-2to3 += "${bindir}/2to3-${PYTHON_MAJMIN}" > FILES_${PN}-pydoc += "${bindir}/pydoc${PYTHON_MAJMIN} ${bindir}/pydoc3" > FILES_${PN}-idle += "${bindir}/idle3 ${bindir}/idle${PYTHON_MAJMIN}" > > -PACKAGES =+ "${PN}-pyvenv" > -FILES_${PN}-pyvenv += "${bindir}/pyvenv-${PYTHON_MAJMIN} ${bindir}/pyvenv" > +# provide python-pyvenv from python3-venv > +RPROVIDES_${PN}-venv += "${PN}-pyvenv" > > # package libpython3 > PACKAGES =+ "libpython3 libpython3-staticdev" > -- > 2.18.0 > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
