Hi Anuj, On Wed, Aug 01, 2018 at 10:43:03AM +0800, Anuj Mittal wrote: > On 07/31/2018 11:22 PM, openembedded-core-boun...@lists.openembedded.org > wrote: > > On Tue, 2018-07-31 at 17:15 +0300, Maxin B. John wrote: > >> qemumips,qemumips64 and x86 based machines include kernel-modules by > >> default. Remove the kernel modules from RRECOMMENDS to make it > >> consistent > >> across the machines. > >> > >> Tested using core-image-sato on qemumips, qemumips64, qemux86 and > >> qemux86-64 > >> > >> [YOCTO #12383] > >> > >> Signed-off-by: Maxin B. John <maxin.j...@intel.com> > >> --- > >> meta/conf/machine/include/x86-base.inc | 2 -- > >> meta/conf/machine/qemumips.conf | 2 -- > >> meta/conf/machine/qemumips64.conf | 2 -- > >> 3 files changed, 6 deletions(-) > > > > Looks good, do we need to add this to genericx86 or anything in meta- > > intel given its changing x86-base.inc? > > > > meta-intel explicitly includes the modules so no change needed there. I > have sent the patch for genericx86 where it should be included now.
Thanks, Just curious why we need to change genericx86. Do we have a list of kernel modules which are required there ? > Thanks, > Anuj Best Regards, Maxin -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
