On Thu, May 24, 2018 at 8:20 PM, Alistair Francis <alistai...@gmail.com>
wrote:
> On Thu, May 24, 2018 at 4:30 PM, Alistair Francis <alistai...@gmail.com>
> wrote:
> > On Thu, May 24, 2018 at 5:27 AM, Bruce Ashfield
> > <bruce.ashfi...@gmail.com> wrote:
> >>
> >>
> >> On Thu, May 24, 2018 at 5:45 AM, Anuj Mittal <anuj.mit...@intel.com>
> wrote:
> >>>
> >>> On 05/03/2018 04:49 AM, Alistair Francis wrote:
> >>> > +KERNEL_FEATURES_append = " ${@bb.utils.contains('MACHINE_FEATURES',
> >>> > 'numa', 'features/numa/numa.scc', '', d)}"
> >>>
> >>> Isn't this enough to pull in the required configuration from
> >>>
> >>>
> >>> https://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-
> cache/tree/features/numa/numa.cfg
> >>>
> >>> If numa.cfg is missing something in yocto-kernel-cache that should be
> >>> applied to all machines, perhaps these configurations should be added
> >>> there?
> >>
> >>
> >> Correct.
> >>
> >> I wanted to run with this patch myself before sending feedback. In
> fact, I
> >> think that the kernel-cache
> >> numa config fragments are being used anyway. But since I'm traveling, I
> >> haven't gotten to that yet.
> >>
> >> Alistair: if you drop your fragment, are you actually getting a failure
> >> during the kernel meta data task ?
> >
> > From memory I didn't see a failure, but I didn't see the NUMA support
> > in the kernel.
> >
> > I'll run a test now.
>
> It looks like the fragment isn't required.
>
> Do you want me to resend the patch with the config fragment removed or
> is something for this already in the works?
>
Go ahead and send the v2. You can add my Acked-by: Bruce Ashfield <
bruce.ashfi...@windriver.com>
on v2 to show that I've reviewed it.
Cheers,
Bruce
>
> Alistair
>
> >
> > Alistair
> >
> >>
> >> I will resubmit my patches shortly that allow any kernel to leverage the
> >> shared config frags, so
> >> using the ones in the kernel cache definitely makes sense.
> >>
> >> Bruce
> >>
> >>
> >>>
> >>> --
> >>> _______________________________________________
> >>> Openembedded-core mailing list
> >>> Openembedded-core@lists.openembedded.org
> >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
> >>
> >>
> >>
> >> --
> >> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at
> >> its end"
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >>
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
