On Mon, May 21, 2018 at 12:13 PM, akuster808 <akuster...@gmail.com> wrote:
> On 05/21/2018 11:18 AM, Andre McCurdy wrote:
>> On Sun, May 20, 2018 at 7:49 AM, Armin Kuster <akuster...@gmail.com> wrote:
>>> From: Armin Kuster <akuster...@gmail.com>
>>>
>>> [v2]
>>> Add back busybox-udhcpc-no_deconfig.patch ti SRC_URI, missed earlier
>>>
>>> [v1]
>>> removed patches included in update:
>>> busybox/CVE-2011-5325.patch
>>> busybox/CVE-2017-15873.patch
>>> busybox/busybox-CVE-2017-16544.patch
>>>
>>> refactored busybox-udhcpc-no_deconfig.patch for this update
>> Did you check the defconfig?
>  That patch does not touch the defconfigs? It changes the dhcpd.c it self.

Right, removing that patch has nothing to do with the busybox
defconfig. I wasn't commenting that particular line in the patch.

>> Often it needs a refresh, otherwise any new config options added
>> between busybox 1.27.2 and 1.28.3 will take busybox's defaults (which
>> may enable new applets or features which we haven't historically
>> enabled when configuring busybox for OE).
> am I missing some context here?

Refreshing (or at least checking) the busybox defconfig is something
that should ideally be done whenever the busybox version is updated
and it wasn't clear from your patch that it's been done, so I just
wanted to double check.
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to