On 05/21/2018 06:55 PM, Jens Rehsack wrote:
Move scripts/bashrc from meta-jens/scripts to oe-core to share user-friendly
oe builddir management with community. Using this script will help manage
multiple BSPs and targets like perl developers using perlbrew.

Please explain in detail what this does, and why is it superior to existing tools. What are the typical usage scenarios? Where and how this should be documented and tested? It is not a good idea to just add something into scripts/, as no one will know or use it, and so it will just quietly bitrot.

+__oe_check_py () {
+    # Make sure we're not using python v3.x. This check can't go into
+    # sanity.bbclass because bitbake's source code doesn't even pass
+    # parsing stage when used with python v3, so we catch it here so we
+    # can offer a meaningful error message.
+    py_v3_check=`/usr/bin/env python --version 2>&1 | grep "Python 3"`
+    if [ "$py_v3_check" != "" ]; then
+        echo >&2 "Bitbake is not compatible with python v3"
+        echo >&2 "Please set up python v2 as your default python interpreter"
+        return 1
+    fi

Bitbake has in fact been compatible with Python 3.x for several releases. The above check is not particularly useful, as /usr/bin/python nearly always points to a 2.x version.

Alex
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to