Re: [OE-core] [PATCH] own-mirrors.bbclass: Change prepend to append

[Bhargava Sreekantappa Gayathri]

> -----Original Message-----
> From: Manjukumar Harthikote Matha
> Sent: Friday, March 09, 2018 9:57 AM
> To: Richard Purdie <richard.pur...@linuxfoundation.org>; Bhargava
> Sreekantappa Gayathri <bsree...@xilinx.com>; openembedded-
> c...@lists.openembedded.org
> Subject: RE: [OE-core] [PATCH] own-mirrors.bbclass: Change prepend to append
> 
> 
> 
> > -----Original Message-----
> > From: Richard Purdie [mailto:richard.pur...@linuxfoundation.org]
> > Sent: Friday, March 09, 2018 5:27 AM
> > To: Bhargava Sreekantappa Gayathri <bsree...@xilinx.com>;
> > openembedded- c...@lists.openembedded.org; Manjukumar Harthikote
> Matha
> > <manju...@xilinx.com>
> > Subject: Re: [OE-core] [PATCH] own-mirrors.bbclass: Change prepend to
> > append
> >
> > On Thu, 2018-03-08 at 17:49 -0800, Bhargava Sreekantappa Gayathri
> > wrote:
> > > If BB_NO_NETWORK is set to 1, and local download directory is added
> > > as PREMIRRORS_prepend in conf file, PREMIRRORS variable will have
> > > SOURCE_MIRROR_URL as the first url. This causes build to fail as
> > > network access is diabled. PREMIRRORS should be appended here so
> > > that a prepend in other layers/conf files takes precedence.
> > >
> > > Signed-off-by: Bhargava Sreekantappa Gayathri
> > > <bhargava.sreekantappa- gayat...@xilinx.com>
> > > Signed-off-by: Manjukumar Matha
> > > <manjukumar.harthikote-matha@xilinx.c
> > > om>
> > > ---
> > >  meta/classes/own-mirrors.bbclass | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I think this patch just moves the problem, you could easily have a
> > file:/// url as SOURCE_MIRROR_URL and a network address in your other
> > layer in which case your patch would break things...
> >
> 
> 
> Agreed.
> I think the better fix would be to go through the entire available list in
> PREMIRRORS skipping http or https  (since BB_NO_NETWORK is set) and then
> fail if we cannot get the required file.

Hi Richard/Manju,

Agreed, I have sent out a patch to fix this issue as discussed.

Thanks,
Bhargav
> 
> Thanks,
> Manju
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core