'exit 1' is not optimal for two reasons:
1) Code is hard to read; it is not obvious that it means 'defer what follows to
first boot'.
2) Worse, this hides actual errors in the scriptlets; there is no difference
between scriptlet
failing because it's intended to be run on target and scriptlet failing because
there's a bug or
a regression somewhere.
The new, supported way is to place the code that has to run on target into
pkg_postinst_ontarget(),
or, if a more fine-tuned control is required, call 'postinst-intercepts
defer_to_first_boot' from
pkg_postinst() to explicitly request deferral to first boot.
Signed-off-by: Alexander Kanavin <alexander.kana...@linux.intel.com>
---
meta/lib/oe/package_manager.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index ea99165d61b..0cc7f3cb3cc 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -604,6 +604,9 @@ class RpmPM(PackageManager):
if line.startswith("Non-fatal POSTIN scriptlet failure in rpm
package"):
failed_scriptlets_pkgnames[line.split()[-1]] = True
+ if len(failed_scriptlets_pkgnames) > 0:
+ bb.warn("Intentionally failing postinstall scriptlets of %s to
defer them to first boot is deprecated. Please place them into
pkg_postinst_ontarget_${PN} ()." %(list(failed_scriptlets_pkgnames.keys())))
+ bb.warn("If deferring to first boot wasn't the intent, then
scriptlet failure may mean an issue in the recipe, or a regression elsewhere.")
for pkg in failed_scriptlets_pkgnames.keys():
self.save_rpmpostinst(pkg)
--
2.15.1
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
