On Thu, Nov 2, 2017 at 10:24 AM, Alexander Kanavin
<alexander.kana...@linux.intel.com> wrote:
> On 11/02/2017 02:21 PM, Otavio Salvador wrote:
>>
>> On Thu, Nov 2, 2017 at 10:19 AM, Alexander Kanavin
>> <alexander.kana...@linux.intel.com> wrote:
>>>
>>> On 11/02/2017 07:39 AM, Khem Raj wrote:
>>>
>>>> Changes since v2: Move to 1.1.18 release
>>>> -PV = "1.1.16+git${SRCPV}"
>>>> +PV = "1.1.18+git${SRCPV}"
>>>
>>>
>>>
>>> Can you drop this, and simply rename the recipe to musl_1.1.18.bb please?
>>
>>
>> Why? keeping it on _git makes sense to me.
>
>
> Only if it's a random development revision (e.g. 1.1.18 plus a bunch of
> commits) - if the version taken is a pristine tagged release, it should be
> indicated as such, regardless of whether it's taken from a tarball or a git
> checkout.I agree partially; if it points to a tag it can be said in a comment ... using SRCPV for this kind of recipe makes sense as it allows for easy tracking of the revision in use. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
