On 2011年08月22日 20:52, Paul Eggleton wrote:
On Monday 22 August 2011 12:34:11 Xiaofeng Yan wrote:
From: Xiaofeng Yan<xiaofeng....@windriver.com>

[YOCTO #999]
Add qt4-x11-demo-image for fixing bug 999
Thanks for looking into this bug. A couple of comments though:

1) You need to specify an appropriate commit message. This should include a
reason for adding (i.e. to allow easy testing of Qt4 on X11); you also need to
credit OE if that's where you copied some of the metadata from.

2) This adds quite a lot more than should be needed for a simple demo image.
The image itself should inherit from core-image, this will save a lot of
duplication. Why are you adding palmtop.bbclass, sdk.bbclass, task-sdk-host,
micro-base-image etc.? These should not be needed at all.

Cheers,
Paul

Thanks for your comments very much. I will make a change for the method to fix bug 999 according to your suggestion.

Thanks
Yan

_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to