Cui, Dexuan wrote on 2011-08-04: > Darren Hart wrote on 2011-08-04: >> On 08/04/2011 12:37 AM, Cui, Dexuan wrote: Please remember to include a >> description of the problem and the approach taken to fix it. This >> eliminates wasted time trying to decipher it later or by people >> unfamiliar with the history. This is important even for simple changes. >> In this case something like: >> >> " The previous fix for a bug in Ubuntu 10.04 readlink, $COMMIT_ID, >> notified the user when a trailing slash was used. As there is no >> semantic difference, simply remove any trailing slashes and proceed >> without nagging the user. " > Thanks! I'll use the description. > >>> diff --git a/scripts/oe-buildenv-internal >> >> This shouldn't be a question. If the documented behavior of readlink >> is to return empty when the path doesn't exist, then assume this to >> be the case. > The latest manual of readlink says readlink should ignore trailing slash. > >> Also, it is a good idea to avoid contractions in printed error messages. >> >> echo >&2 "Error: the directory $PARENTDIR does not exist." > Ok, I'll change "doesn't" to "does not". > >> Otherwise, this looks good to me. > Please review the new patch (I paste it at the end of the mail, too) > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dcui/bug-671&id=593e3506f4d4d9f6030100eac8c8e0af7f8ce3eb Hi Darren, Could you please comment on this new version of patch? I sent it out for several days ago. Maybe it was drowned in the mailing list.
Thanks, -- Dexuan _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
