On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'

Have you discussed that with upstream?  If not, are you confident that
preferring cpio will not simply mean that we are swapping one deficiency
for another?

> +Index: automake-1.11.1/Makefile.in
> +===================================================================
> +--- automake-1.11.1.orig/Makefile.in
> ++++ automake-1.11.1/Makefile.in
> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
> +     $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
> +     $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
> +     $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
> +-    $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
> ++    $(top_srcdir)/m4/substnot.m4 \
> +     $(top_srcdir)/configure.ac
> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
> +     $(ACLOCAL_M4)

Can you explain why this hunk is necessary?

> +do_configure () {
> +     touch ${S}/Makefile.in
> +     autotools_do_configure
> +}

... and this one?

Also, your patch is missing a Signed-off-by line.  See:

http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Patch_Headers_and_Commit_Messages

p.


_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to