2011/7/28 Ben Gardiner <bengardi...@nanometrics.ca> > > > Well, I would not submit _this_ patch for pull-request. I was hoping > to get this version of raptor included and then submit a pull-request > for a cherry-pick of the patch to add libxml2 to DEPENDS. >
Ah, missed that you also added libxml2. Not sure about the policies of the maintenance branch, but I suspect the proper way would be to fix and test in openembedded then submit a pull request. Then again maybe the policies for the maintenance branch are different. [...] > >> > http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Example:_Importing_from_Elsewhere_Modified > > > > Ah ok, Those guidelines are fairly new and I was not too aware of them. > If > > it is in accordance with the guidelines it is fine with me to keep them. > > I was mainly triggered by the signed-off lines at the beginning of your > > message (which I don't think are in accordance to the above mentioned > > guidelines). > > > Oh. I thought they were [in accordance]. I guess there would usually > be a commit body before the initial Signed-off-by:'s ; however, there > was no original commit body to preserve. > Ah ok, understood. Actually, I guess we should preserve the first line of the commit too. This is what git log says: frans@frans-desktop:~/workspace/openembedded/recipes/raptor$ git log * commit 01e8e9f325d8d251e852e7a5704b5fe50880e1ad Author: Frans Meulenbroeks <fransmeulenbro...@gmail.com> Date: Sat Aug 14 21:27:49 2010 +0200 raptor: added recipe Signed-off-by: Frans Meulenbroeks <fransmeulenbro...@gmail.com> Best regards, Frans.
_______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
