Hi all, Ive committed the Reader changes successfully, all checks passed.
Im having some trouble committing the writer, I’m failing the appveyor test for the wlnformat.cpp file. I have a feeling I’ve got the WriteMolecule function wrong! Please could someone have a look and let me know what I’ve done wrong? Pull request #2511 Cheers, Mikey On 11 Jul 2022, 18:17 +0100, m.k.bla...@icloud.com, wrote: > I have sent a pull request for the reader, writer on the way > > Mikey > On 9 Jul 2022, 18:51 +0100, m.k.bla...@icloud.com, wrote: > > Hi Geoffrey, > > > > Sorry just fixing the last few edge cases and making sure the bugs are all > > out! > > > > Will pull request once I’ve got the ring bridges to play ball! > > > > Happy with Git! > > > > Mikey > > On 9 Jul 2022, 18:45 +0100, Geoffrey Hutchison <geoff.hutchi...@gmail.com>, > > wrote: > > > Hi Michael, > > > > > > I just wanted to check in. If submitting through GitHub is too much > > > trouble, I'm sure Noel or I could help create the patches, etc. if you > > > can send the code. > > > > > > Thanks, > > > -Geoff > > > > > > > > > > On Jun 16, 2022, at 3:56 AM, Michael Blakey via OpenBabel-discuss > > > > <openbabel-discuss@lists.sourceforge.net> wrote: > > > > > > > > Hi There, > > > > > > > > I have made changes to Rogers code to expand the WLN reader > > > > capabilities to cover significantly more of the language space. I have > > > > also created a Writer that will go from Mol object to WLN notation and > > > > would like to add the ‘win’ format to obconversion following > > > > publication of the work. > > > > > > > > What is the best way to submit these to OpenBabel for unit testing and > > > > hopefully release? > > > > > > > > Michael Blakey > > > > University of Southampton > > > > Placement student of NextMove Software > > > > > > > > _______________________________________________ > > > > OpenBabel-discuss mailing list > > > > OpenBabel-discuss@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/openbabel-discuss > > >
_______________________________________________ OpenBabel-discuss mailing list OpenBabel-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
