I agree (about the docs). Could you make the change? You can do it directly
on github. I can supply more details if you are not familiar with the
process.
On Fri, 10 Aug 2018, 17:11 Nathan Jenkins, <xmdwpl...@gmail.com> wrote:
> You should update the documentation for OpenBabel::OBMol GetCoordinates()
> to make it more obvious the pointer returned is the internal array.
> Normally get functions return copies, not direct access to the data.
> Alternatively the code can be refactored to use a shared pointer to make
> the intent self documenting.
>
> --
> Nathan
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> OpenBabel-discuss mailing list
> OpenBabel-discuss@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
>
On 10 Aug 2018 17:11, "Nathan Jenkins" <xmdwpl...@gmail.com> wrote:
You should update the documentation for OpenBabel::OBMol GetCoordinates()
to make it more obvious the pointer returned is the internal array.
Normally get functions return copies, not direct access to the data.
Alternatively the code can be refactored to use a shared pointer to make
the intent self documenting.
--
Nathan
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenBabel-discuss mailing list
OpenBabel-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenBabel-discuss mailing list
OpenBabel-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
