On Mar 9, 2019, at 8:28 PM, [email protected] wrote: > > I can see how "on-failure" might make more sense. This would mean that > iscsid would not restart if `iscsid -k` is executed while iscsid is enabled > under systemd. Is this acceptable? If so, I'll submit an updated patch.
This makes more sense to me, under the “do least harm” philosophy. I can only assume somebody (with root access) really wants to stop iscsid, but does not want to stop the iscsid.service if they specifically tell iscsid to stop. This seems less bad than the other approach, which would be to re-start iscsid when somebody explicity told it to stop. Either way, one must wonder why somebody would tell iscsid to stop without stopping the systemd service … :) Yes, please resubmit your patch. Or if you prefer using github you can submit a pull request there. > > On Friday, March 8, 2019 at 12:12:03 PM UTC-5, The Lee-Man wrote: > On Thursday, February 21, 2019 at 2:35:46 PM UTC-8, [email protected] <> > wrote: > From: Fred Herard <[email protected] <>> > > This change adds Restart=always systemd service option to iscsid.service > config file so that iscsid daemon is always restarted. This is > particularly useful when using iscsi boot device and iscsid daemon > crashes or is inadvertently killed. > --- > etc/systemd/iscsid.service | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/etc/systemd/iscsid.service b/etc/systemd/iscsid.service > index f5e8979..e22b372 100644 > --- a/etc/systemd/iscsid.service > +++ b/etc/systemd/iscsid.service > @@ -10,6 +10,7 @@ Type=notify > NotifyAccess=main > ExecStart=/sbin/iscsid -f > KillMode=mixed > +Restart=always > > [Install] > WantedBy=multi-user.target > -- > 1.8.3.1 > > > I'm not sure I agree with "always". I believe "on-failure" might make more > sense? > > The daemon iscsid only does an "exit(0)" if it is exiting cleanly, so why > would we restart the service in that case? -- Lee Duncan "God is a comedian playing to an audience too afraid to laugh." -- Voltaire -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
