>
>
> > The actual maximum is really 16777212 since 16777212 & 0x03 == 0, 
> > which will cause it to pass thru the _padding function with no change. 
> > 
>
> Nice catch. Yeah, it is a bug in the iscsi code as far as I can tell. I 
> should be able to send a patch shortly. 
>
> Just curious, did you have a need for a Length this large, or were you 
> just testing? 
>


Just testing.  I noticed that the maximum length of the read requests that 
TGT was handling was only 128K and was trying to get it to handle larger 
values.  Making it the max didn't help. I think the size of the read 
request actually comes from the iscsi initiator anyway so I wasn't looking 
in the right place.  Im looking at open-iscsi now...



> > The _padding issue probably affects other parameters as well, thats 
> > the one where I first noticed the problem. 
> > 
>
> It does. 
>
 

Thanks for the patch!

-Wyllys
 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Reply via email to