If an ipaddress is setup for a chelsio interface, then /sys/class/iscsi_host/ip_address returns the ip address from the netdev correctly, otherwise it is all zeros. It will always return the value from netdev, since we don't actually support setting iface.ipaddress in the transport -Anish ________________________________________ From: Mike Christie [[email protected]] Sent: Thursday, July 24, 2014 9:21 AM To: [email protected] Cc: Anish Bhatt; Karen Xie; Anish Bhatt Subject: Re: [PATCH] iscsiadm : make iface.ipaddress optional in iface configs for transports that don't have a hard requirement on it.
On 07/24/2014 01:14 AM, Anish Bhatt wrote: > From: Anish Bhatt <[email protected]> > > Signed-off-by: Anish Bhatt <[email protected]> > --- > usr/initiator_common.c | 15 ++++++++++++--- > usr/transport.c | 8 ++++---- > usr/transport.h | 6 ++++++ > 3 files changed, 22 insertions(+), 7 deletions(-) > > diff --git a/usr/initiator_common.c b/usr/initiator_common.c > index 50f8d41..8ff993d 100644 > --- a/usr/initiator_common.c > +++ b/usr/initiator_common.c > @@ -685,9 +685,18 @@ int iscsi_host_set_net_params(struct iface_rec *iface, > > /* if we need to set the ip addr then set all the iface net settings */ > if (!iface_is_bound_by_ipaddr(iface)) { > - log_warning("Please set the iface.ipaddress for iface %s, " > - "then retry the login command.\n", iface->name); > - return EINVAL; > + if (t->template->set_host_ip == SET_HOST_IP_REQ) { > + log_warning("Please set the iface.ipaddress for iface " > + "%s, then retry the login command.\n", > + iface->name); > + return EINVAL; > + } else if (t->template->set_host_ip == SET_HOST_IP_OPT) { > + log_info("Optional iface.ipaddress for iface %s " > + "not set.\n", iface->name); > + return 0; > + } else { Is there a way to tell if it was not set in the iface config file but is actually already set in the driver/kernel already? If I read the /sys/class/iscsi_host/ip_address file will that return the value from the netdev that will be used or the already setup value? -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
