Any update ? On Tue, Aug 30, 2011 at 8:44 PM, Vivek S <[email protected]> wrote:
> Added comments for structures and functions. > > As for being a masochist, I tried, but couldn't take it ;-P. > > > On Tue, Aug 30, 2011 at 12:31 PM, Ulrich Windl < > [email protected]> wrote: > >> >>> Vivek S <[email protected]> schrieb am 29.08.2011 um 21:00 in >> Nachricht >> <CAAPU5rPY1F3bkYYyASAFbOtb6JrfGw7JSb6m=--KKUEZVmc=w...@mail.gmail.com>: >> > Removed ordering constrains between #defines and structure elements. >> > Removed calculating tab width and defaulting to 8. >> > >> > Hope this will do :-) >> >> Hi! >> >> It looks like converging ;-) >> >> You could (I know it's non-hacker-like) add some comments on the struct >> def: >> >> int option; >> char *option_str; >> const char *help_str; >> >> BTW: shouldn't "option_str" be "const char" also? >> >> On >> +/* >> + * Global defines for all iscsiadm command line options. >> + */ >> +#define CMD_LINE_OPTION_PORTAL (1 << 0) >> >> Improve the comment by saying why you use bitmasks there, or say what >> those defines are going to be used for. >> >> If you feel like a masochist today, you could temporarily add some of the >> gcc options that I used myself years ago: >> -Wall -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings >> -Wtraditional -Wstrict-prototypes -Wnested-externs -Wredundant-decls >> -Wconversion >> >> Maybe this helps you to clean out a few edges. >> >> Regards, >> Ulrich >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "open-iscsi" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/open-iscsi?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
