On 08/26/2011 01:16 PM, Eddie Wai wrote:
> The iscsi_nopout task's TTT is defined as __be32 while the DMA
> memory to the chip is CPU specific.  This creates a problem for
> unsolicited NOP-In responses where the TTT is not the RESERVED
> tag of 0xFFs.  This patch adds a call to be32_to_cpu for the TTT
> specified.
> 
> Signed-off-by: Eddie Wai <[email protected]>
> ---
>  drivers/scsi/bnx2i/bnx2i_hwi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
> index 9ae80cd..dba72a4 100644
> --- a/drivers/scsi/bnx2i/bnx2i_hwi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
> @@ -563,7 +563,7 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn *bnx2i_conn,
>       nopout_wqe->itt = ((u16)task->itt |
>                          (ISCSI_TASK_TYPE_MPATH <<
>                           ISCSI_TMF_REQUEST_TYPE_SHIFT));
> -     nopout_wqe->ttt = nopout_hdr->ttt;
> +     nopout_wqe->ttt = be32_to_cpu(nopout_hdr->ttt);
>       nopout_wqe->flags = 0;
>       if (!unsol)
>               nopout_wqe->flags = ISCSI_NOP_OUT_REQUEST_LOCAL_COMPLETION;


Looks ok.

Reviewed-by: Mike Christie <[email protected]>

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.

Reply via email to