On 02/11/2011 01:34 AM, Ulrich Windl wrote:
Hi!
It seems the code to print the signal number is somewhat ... aehm.. see
yourself:
# iscsid -d8 -f
[...]
iscsid: Max file limits 1024 8192
iscsid: in ctldev_close
iscsid: reaped pid 20349, reap_count now 0
^Ciscsid: 2 caught signal -20348...
iscsid: event_loop interrupted
[...]
# kill %1
iscsid: 15 caught signal -20348...
iscsid: iscsid shutting down.
iscsid: in ctldev_close
Found in SLES11 SP1 (open-iscsi-2.0.871-0.22.1)
Regards,
Ulrich
P.S. Doesn't "gcc -Wall" warn about such things?
It should be fixed now in upstream git. It was not a programming error.
It was just a bad debug message:
log_debug(1, "%d caught signal -%d...", signo, getpid())
so the first number was the signal, then at the end there was a "-" and
then the pid. So -Wall would not help since it does not protect against
poor log message writing on my part or wherever the msg came from :)
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
