Mike,
On Tuesday, February 01, 2011 4:37 PM, Mike Christie wrote:
>
> On 02/01/2011 05:10 PM, Mark Rustad wrote:
> > +static int get_link_ifname(const char *ifname, char *link_ifname)
> > +{
> > + int ifindex;
> > +
> > + if (sysfs_get_int(ifname, "net", "iflink",&ifindex))
> > + return EIO;
>
> In the rest of the code you use -EXYZ, but here you use the positive
> value. You meant -EIO, right? I can fix that up on merge.
Good catch. You are absolutely right, that is what I intended (though it doesn't
matter functionally in this case). Using the negative values for errors leaves
open the possibility of returning a length or something, so I tend to want to do
it that way.
--
Mark Rustad, LAN Access Division, Intel Corporation.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
