On 01/07/2011 04:45 PM, [email protected] wrote:
[PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info.
From: Karen Xie<[email protected]>
Remove gl_skb from cxgbi_ddp_info as it is only used by cxgb3i.
Signed-off-by: Karen Xie<[email protected]>
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 51 +++++-------------------------------
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 -
drivers/scsi/cxgbi/libcxgbi.c | 15 +----------
drivers/scsi/cxgbi/libcxgbi.h | 3 --
4 files changed, 8 insertions(+), 63 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index a129a17..e2362b9 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -1108,10 +1108,11 @@ static int ddp_set_map(struct cxgbi_sock *csk, struct
cxgbi_pagepod_hdr *hdr,
csk, idx, npods, gl);
for (i = 0; i< npods; i++, idx++, pm_addr += PPOD_SIZE) {
- struct sk_buff *skb = ddp->gl_skb[idx];
+ struct sk_buff *skb = alloc_wr(sizeof(struct ulp_mem_io) +
+ PPOD_SIZE, 0, GFP_ATOMIC);
I think you want to try to avoid lots of little GFP_ATOMIC allocations
in the main IO path, because it probably is bad for performance and
because they can fail and you can be stuck with no mem but other
allocations needing to write data out.
Did you want to just make each driver allocate a pool/map, then allocate
from that pool/map in these places (cxgb4i does a similar skb allocation
at these points right?)?
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
