> -----Original Message----- > From: Mike Christie [mailto:[email protected]] > Sent: Wednesday, November 03, 2010 12:36 PM > To: [email protected] > Cc: Anish Bhatt; Benjamin Li > Subject: Re: case sensitivity of hardware addresses & vlan configs > > ccing Ben Li from Broadcom. > > > On 11/02/2010 06:42 PM, Anish Bhatt wrote: > > MAC addresses specified in iface files are currently case sensitive. > > This can be an issue on vlan interfaces, as isciadm -m iface does not > > create config files for vlan interfaces and they need to be written > > manually. Attached patch will convert uppercase MAC addresses to > lower > > case after reading them (iscsiadm expects them in lower case only). > > > > > > > > There seems to be another issue with VLAN interfaces. Interface > files > > for offloaded vlan interfaces (on chelsio cards atleast) need a > hardware > > address to be specified to work. As of now, iscsiadm does not catch > this > > So for software iscsi and vlans, you just need to specify the netdev > vlan name (for example eth0.1 for the iface.net_ifacename). You do not > need to set the hwaddress/mac in the iface.
For cxgbXi with vlan interfaces, if hwaddress is not specified iscsiadm cannot resolve a hostno; and this further causes scsi_host_lookup to fail, resulting in an incorrect scsi_host being passed to libcxgbi. Not sure if this is Chelsio specific, but it differs from software iscsi behavior. > > iscsiadm does not catch what you need for offload because I had no idea > you were doing this. > > For chelsio offload how are you guys specifying things when vlans are > used and what does cxgb3i export? Do you have to create a vlan with the > normal linux tools like vconfig first, then for the net_ifacename are > you specifying the vlan name created by vconfig? > cxgbi_device_find_by_netdev then matches the names with the real > netdev? > > Why do you need to pass in the hardware address? Yep, exactly what we do. vconfig + specify interface name and ip in iface file. For reasons mentioned above, VLAN interfaces do need a hardware address to be specified. > > There was talk about adding a vlan id: > http://groups.google.com/group/open- > iscsi/browse_thread/thread/7ee3b5bb5502871b/37fe62da7d1ffa4e?lnk=gst&q= > Using+IFACE_SUBNET_MASK+and+IFACE_VLAN#37fe62da7d1ffa4e > so we could have a more common way of specifying the vlan to be used. > > > > and will simply fail. This is already noted in the readme, but would > > What note in the readme are you referring to? Sorry, I meant the cxgbXi readme. Current solution right now is to tell end users to specify a hardware address with vlan interface files. I'd like to add that once in a while, I have seen 'iscsiadm -m iface' create iface files for vlan interfaces, and here the hwaddress gets written in uppercase, rather than the lower case required. This is not easily reproducible and creates issues due to case sensitivity. > > there be any interest in adding functionality to 'iscsiadm -m iface' > to > > handle vlan interfaces, or warn about missing hwaddress keys when it > > comes to offloaded vlan interfaces ? > > > > -Anish > > > > > > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
