simgunz updated this revision to Diff 67517. simgunz added a comment.
- Rename favorite > quick in settings - Refactor - Clean pageviewutils - Increase part.rc version - Improve tools defaults - Clean code - Remove unused method - Rename methods - Rename, move and comment methods - Fix quickTools - Move methods - Move / rename methods - Make methods private - Update description - Move methods to original position - Improve checks - Minor style change - Rename methods favorite > quick - Reorder methods - Move methods to private class - Correctly disable all actions when annotations not allowed - Rename variables - Indent - Clean parseTool - Code style fixes - Clean constructor - Remove unuseful signal - Simplify code to set picker color - Clean tooltips method - Clean populate quick annotation - Clean icons generator method - Reorder methods - Rename method - Simplify deselecting tool code - Put similar methods close together - Add method description - Remove unuseful connection - Remove comment - Add comments regarding action group workaround - Refactor stamp tool code - Comments - Remove unused code - Drop unuseful slots - Simplify updateConfigActions method - Use new edit-line-width icon - Refactor method to set color picker icon - Fix stamp tool not properly selected - Refactor parseTool - Refactor updateConfigActions: remove none, no annotation tooltips - Use isValid instead of setting Qt::transparent - Spaces - Move instruction at the end - Refactor insertion of custom action (width and opacity) - Move code to select stamp action in a method - Style REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=67036&id=67517 BRANCH annotation-toolbar-refactor REVISION DETAIL https://phabricator.kde.org/D15580 AFFECTED FILES CMakeLists.txt conf/dlgannotations.cpp conf/dlgannotationsbase.ui conf/editannottooldialog.cpp conf/editannottooldialog.h conf/okular.kcfg okular.upd part.cpp part.rc shell/shell.cpp shell/shell.h shell/shell.rc ui/annotationactionhandler.cpp ui/annotationactionhandler.h ui/annotationwidgets.cpp ui/annotationwidgets.h ui/data/CMakeLists.txt ui/data/tools.xml ui/data/toolsQuick.xml ui/pageview.cpp ui/pageview.h ui/pageviewannotator.cpp ui/pageviewannotator.h ui/pageviewutils.cpp ui/pageviewutils.h ui/side_reviews.cpp ui/toggleactionmenu.cpp ui/toggleactionmenu.h ui/toolaction.cpp ui/toolaction.h To: simgunz, #okular, #vdg Cc: simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
