alex-l added a comment.
In T10243#201379 <https://phabricator.kde.org/T10243#201379>, @ndavis wrote: > In T10243#201333 <https://phabricator.kde.org/T10243#201333>, @ngraham wrote: > > > In T10243#201329 <https://phabricator.kde.org/T10243#201329>, @alex-l wrote: > > > > > EDIT: I have already said this here and there but please don't run any automated script to SVG icons, because when opening them back in Inkscape they are corrupted and everytime I edit a Breeze icon I have to do additional work to fix shapes and gradients corrupted by the scripts. > > > > > > This is something you should bring up in the VDG chatroom and discuss with @ndavis in particular as we currently make heavy use of these scripts for optimization purposes. Hopefully we can come up with a solution together. > > > I actually hand check for errors when I optimize. If the gradients are out of place, then I put them back into place, optimize again and check again. Usually, the gradients get messed up when they're missing some data that is supposed to be in there and they get optimized with SVG Cleaner. If you ever see `Warning: The 'stop' element must have an 'offset' attribute. Fallback to 'offset=0'.`, you need to check the gradients. > > There are a fair amount of icons with gradient handles that are lined up right, but are way off to the side. Those were there before I started working on breeze-icons and I fix them as I go. Most common problems for me are: (1) path that is correctly displayed but can't be edited with Inkscape, just moved around and (2) gradient correctly displayed but Inkscape's UI says the filling is "?" instead of gradient. You can check (2) with current 48x48 icon for Konsole/terminal, the shape is the ">" symbol. TASK DETAIL https://phabricator.kde.org/T10243 To: alex-l Cc: IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender
