aacid added a comment.
I'm not very convinced with the tests.
You have \n but the rects are all one after the other, so the algorithm that
does the line partition doesn't really see a line there, you should have them
in different row rects so that they are actually different physical lines.
The "Across Lines not find" doesn't really test what you want, you "want" to
test that it finds the last entry, but since the only thing you're checking is
that it finds stuff and not in which rects it finds them, it may very well be
finding "ab\na"
Same thing for Hyphen doesn't count
Am i making sense?
INLINE COMMENTS
> textpage.cpp:867
> + int len = stringLengthAdaptedWithHyphen(strNotUsed, it,
> m_words.constEnd());
> + QString str = QString(strNotUsed).replace('\n', ' ');
>
const
> textpage.cpp:986
> + int len = stringLengthAdaptedWithHyphen(strNotUsed, it,
> m_words.constEnd());
> + QString str = QString(strNotUsed).replace('\n', ' ');
>
const
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D19717
To: joaonetto, #okular
Cc: aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
