ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
Looks great to me. Please wait to land this until @aacid or another Okular developer is okay with bumping the Frameworks dependency to 5.56. BTW @aacid, what's your objection about doing this, out of curiosity? People on rolling release distros will surely have 5.56 by the time Applications 19.04.0 is released, and once time discrete release distros get around to shipping 19.04.0, I expect that they'll have already shipped a new enough version of Frameworks, if not even newer. Also @ognarb, now that I see all these patches, I'm wondering if it might make sense to create two new Kirigami components, each based on your very nice `ActionTextField`: - `SearchField`, which includes all the search field boilerplate that you're adding here (keyboard shortcut, clear button, placeholder text, etc) - `PasswordField`, which has a clear button as well as a "show password" button. This would be very Kirigami-ish, in the spirit of providing high-level controls so that apps don't need to reinvent the wheel all the time. And then we would have total UI consistency for all instances of these fields. REPOSITORY R223 Okular BRANCH arcpatch-D18658 REVISION DETAIL https://phabricator.kde.org/D18658 To: ognarb, #okular, ngraham Cc: aacid, ngraham, okular-devel, tfella, darcyshen
