aacid added a comment.
In D18144#406831 <https://phabricator.kde.org/D18144#406831>, @joaonetto wrote: > I don't know a lot about autotests, therefore I'm not so sure that it is implemented correctly. I can implement it, but I would need some assistance. Your test isn't testing anything, you added new rows, but you're not doing anything with them. The test should be doing something like, if there's a find string, check that the text was actually searched (and found if it's on the file) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18144 To: joaonetto, #okular Cc: ngraham, aacid, yurchor, okular-devel, tfella, darcyshen
