sander created this revision. sander added a reviewer: Okular. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. sander requested review of this revision.
REVISION SUMMARY The 'current generators' dialog has a page for each generator. The choice of which of these pages is visible when the dialog is first opened seems to be random (or at least I don't see the pattern). This patch makes sure that the currently running generator determines which page is opened, because in most cases people will want to set preferences for the generator they are currently using. Unfortunately, I had to change the interface of Okular::ConfigInterface for this. Speak up if you know a better way. TEST PLAN 1. Open Okular with a pdf file 2. Open Settings -> Configure Backends 3. Notice how the dialog opens with the pdf settings right away 4. Open (e.g.) a markdown file 5. Open Settings -> Configure Backends 6. Notice how the dialog opens with the markdown settings right away REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14809 AFFECTED FILES core/document.cpp core/textdocumentgenerator.cpp core/textdocumentgenerator.h generators/fictionbook/generator_fb.cpp generators/fictionbook/generator_fb.h generators/markdown/generator_md.cpp generators/markdown/generator_md.h generators/ooo/generator_ooo.cpp generators/ooo/generator_ooo.h generators/poppler/generator_pdf.cpp generators/poppler/generator_pdf.h generators/txt/generator_txt.cpp generators/txt/generator_txt.h interfaces/configinterface.h To: sander, #okular Cc: okular-devel, ngraham, aacid
