michaelweghorn added inline comments.
INLINE COMMENTS
> michaelweghorn wrote in generator_pdf.cpp:151
> Should this be `m_scaleMode->insertItem(FitToPage, i18n("Fit to page"),
> FitToPage);` (and likewise for all other calls to `insertItem` below?
> Otherwise a `QVariant()` is inserted.
Or maybe using sth else as index might be a good option as well. I did not
test, but using `enum class` instead of `enum` might have triggered a compile
error right away.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7962
To: sander, #okular, aacid
Cc: okular-devel, cfeck, rkflx, michaelweghorn, ngraham, aacid
