> On Oct. 17, 2015, 10:17 p.m., Albert Astals Cid wrote: > > If you are doing a text select over a link (i.e. you click and start > > dragging on a link), i think the cursor should go back to the beam cursor, > > what do you think? > > Olivier Churlaud wrote: > @aacid: What is the status of this review? > > Albert Astals Cid wrote: > I made a question, it has been unanswered, that's all i know. > > Olivier Churlaud wrote: > Don't you think this could be added to master for the feature it brings > and then add the 2 options you proposed (minor change) later? > > This is a really good feature, and if your 2 questions are the only thing > holding back, I think merging it would be great. Else I can try to finish > them and update the patch. What do you think?
I'm going to be closing this since we landed https://git.reviewboard.kde.org/r/130246/ - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/#review86987 ----------------------------------------------------------- On Sept. 15, 2015, 5:41 a.m., Jake Linder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124961/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 5:41 a.m.) > > > Review request for Okular and Albert Astals Cid. > > > Bugs: 318078 > http://bugs.kde.org/show_bug.cgi?id=318078 > > > Repository: okular > > > Description > ------- > > Supercedes https://git.reviewboard.kde.org/r/124723/: > > - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature) > - Drop the refactoring patch (seperate problem), sticking with the code > duplication for now. > - Added seperate patch (post changes) fixing whitespace issue in gargantuan > switch statement. Take it or leave it. > > > Diffs > ----- > > ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 > > > Diff: https://git.reviewboard.kde.org/r/124961/diff/1/ > > > Testing > ------- > > - cursor switches to Hand when hovering over link in TextSelect mode. > - clicking on hyperlink jumps to destination in TextSelect mode. > - text selection & copy still works. > - can text-select "over and across" hyperlink. > - can text-select starting at text and ending selection in middle of > hyperlink. > - can text-select starting from hyperlink with click and drag. > - can jump to link while there's an active selection of text. > - can jump to link while there's an active selection spanning a hyperlink. > - doesn't crash when switching away from window and back + clicking off page > - when textselect overlaps a link, r-click on the link gives the "follow this > link" content menu, r-click off link gives the "Copy Text"/etc' context menu > - text selection works when selecting left to right or right to left > (begin/end selection works out no matter in what order user provides them) > > > Thanks, > > Jake Linder > >
