davidedmundson added a comment.

  From my POV (pending a reply from Sander) this is good to go.

INLINE COMMENTS

> pageviewannotator.cpp:1122
> +        imageVariant = "@2x";
> +    } else {
> +        imageVariant = "";

that's a redundant else branch, and it won't get optimised out as technically

QString() is different from QString("");

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6268

To: hetzenecker, davidedmundson, aacid
Cc: sander, anthonyfieroni, #okular, aacid

Reply via email to